Feature/ratio3d #13
Open
Feature/ratio3d #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikeowen
pushed a commit
that referenced
this pull request
Aug 6, 2020
* commit '0f74c61ae0d0a09856cc2e061a84e38a4755ea50': Adding an ENABLE_DOCS CMake flag which allows choosing whether or not to build the documentation. Defaults to Off. Hardwiring sphinx to be the Spheral built one, and adding a few more dependencies for the docs build. Removed a debug message. Fixing notations for default options. Default readthedocs sphinx theme Setting default readthedocs sphinx theme Need a symlink called contents.rst for readthedocs. Adding support for readthedocs. First pass at build instructions. Starting rst documentation.
|
@jmikeowen @antimatterhorn Per the move to a Develop/Release/Master gitflow I have changed the base branch of this PR to develop. |
|
@jmikeowen This PR is 4 years old, should we close it? It can be opened again if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated this branch with master, and it appears the test Cody wrote is doing the same thing in (X,Y,Z) as expected.
If we unflip the z generation direction it also looks good:
so I think this is ready to go.