Improve target export #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SpheralC to use when necessary, removed BLT path export
mdavis36
reviewed
Mar 5, 2024
cmake/spheral_cxx-config.cmake.in
Outdated
Comment on lines
18
to
26
| set(CMAKE_C_COMPILER "@CMAKE_C_COMPILER@" CACHE PATH "Spheral C compiler path") | ||
| set(CMAKE_CXX_COMPILER "@CMAKE_CXX_COMPILER@" CACHE PATH "Spheral C++ compiler path") | ||
| set(CMAKE_Fortran_COMPILER "@CMAKE_Fortran_COMPILER@" CACHE PATH "Spheral C++ compiler path") | ||
| endif() | ||
| set(SPHERAL_ENABLE_MPI @ENABLE_MPI@ CACHE BOOL "") | ||
| if(SPHERAL_ENABLE_MPI AND NOT DEFINED MPI_C_COMPILER) | ||
| set(MPI_C_COMPILER "@MPI_C_COMPILER@" CACHE PATH "") | ||
| set(MPI_CXX_COMPILER "@MPI_CXX_COMPILER@" CACHE PATH "") | ||
| set(MPI_Fortran_COMPILER "@MPI_Fortran_COMPILER@" CACHE PATH "") |
There was a problem hiding this comment.
Is this going to set the compilers for every project that tries to include Spheral in it's CMake system? I think we might want to prefix these variable names with "SPHERAL_" so we aren't unintentionally forcing projects to use our compiler and MPI
There was a problem hiding this comment.
That was a concern of mine. I originally had it prefixed with SPHERAL but that didn't work because I think those flags needed to be set before spheral_cxx-targets is included. I hoped that guarding the sets with checks for whether they are already defined would be enough to prevent issues for other projects that already have those variables set. That was one of the things I hope Paul can try out.
mdavis36
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with target exports when using SpheralC.
Summary
ToDo :
RELEASE_NOTES.mdwith notable changes.