[WIP] Squashed Warnings Pyb11 Modules #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geModel for declaration in pybind11 module.
…ged function signature.
… 'throw will always terminate' warning from DBC.hh
…g increasingly difficult to manage generated local typedef instantiations without significant changes to how PYB11Generator. Since we aren't writing these cpp files explicitly this is less favourable but reasonable.
|
I saw the commit turning off warnings for unused typedefs in PYB11 modules. I think this is a good change -- it's actually more work for the developer adding & removing typedefs for each class I think, and having some blanket typedefs does not seem harmful. |
jmikeowen
approved these changes
Sep 16, 2020
MishaZakharchanka
approved these changes
Sep 16, 2020
jmikeowen
pushed a commit
that referenced
this pull request
Dec 23, 2020
…ig to develop * commit '2ef3319df2eac1bfb22f33592bb29198afcac44d': Updated build docs with ENABLE_OPENSUBDIV option. Adding a cmake flag ENABLE_OPENSUBDIV to explicitly control whether Opensubdiv should be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR squashes all warnings for a complete Spheral Python modules build with GCC.
Changes
Set CMake warnings flag to ON.
Silence unused-local-typedef warnings for all Spheral python modules. This is necessary due to the way in which PYB11Generator creates the pybind11 .cc Spheral files.
Silence terminate warning on SpheralSilo.cc. This is tracked down to a VERIFY2 macro call from DBC.hh which throws this error. (An issue will be created to track this in the future).
Silence uninitialized-variable from bisectSearch. This is being caused by some issue in the boost multi-array Iterator. (Issue will be created).
Various unused-parameter, sign-conversion, unused-variable warnings throughout.
Pybind11Wraps function signature fixes. Missing args, const/non-non const, return types etc.