-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang Build Fixing Errors and Warnings #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaders, this satisfies undefined-var-template warnings.
…, because of multiple definitions. Not sure about this, but we are turning off undefined-var-templates for now anyway.
mdavis36
changed the title
[WIP] Clang Build Fixing Errors and Warnings
Clang Build Fixing Errors and Warnings
Oct 1, 2020
MishaZakharchanka
approved these changes
Oct 1, 2020
jmikeowen
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only question is about moving back to boost::unordered_map from std::unordered_map. We've been trying to go to the std:: versions as they're available -- what's up with clang?
jmikeowen
pushed a commit
that referenced
this pull request
Mar 19, 2021
* commit '655f48309d25f1e9c06c91412aa2933a4f6e73ca': Setting host configs to not use prebuilt PolyClipper on LC machines. This should be reversed when we update the prebuilt version of PolyClipper. typo Updates to use v1.2.0 of PolyClipper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing errors and warnings for building spheral with clang. Clang seems to be a little more picky so it was able to pick up some things that weren't reported with gcc.
Changes