Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SynchronousRK2.cc #63

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Update SynchronousRK2.cc #63

merged 1 commit into from
Apr 22, 2021

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Apr 15, 2021

Flipped ordering of initializeDerivatives & derivs.zero to be consistent w/ the other integrators.

@jmpearl
Update SynchronousRK2.cc
44678c2 
Flipped ordering of initializeDerivatives & derivs.zero to be consistent w/ the other integrators.
@jmikeowen
Copy link
Collaborator

Ah, makes sense to be consistent. Have you run the full ATS test suite to ensure everything is passing with this change?

@jmpearl
Copy link
Collaborator Author

jmpearl commented Apr 21, 2021

ATS came back clean

jmikeowen
jmikeowen approved these changes Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the ATS testing passing, should be good to go.

@jmikeowen jmikeowen merged commit cd3d74c into develop Apr 22, 2021
@jmpearl jmpearl deleted the SRK2-minor-patch branch April 22, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmpearl @jmikeowen