Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/build without network #66

Merged
merged 6 commits into from
May 1, 2021
Merged

Conversation

jmikeowen
Copy link
Collaborator

No description provided.

@jmikeowen
Copy link
Collaborator Author

This merge updates our TPL build rules so we can successfully build when there is no network connection. This relies on either pre-installing the TPLs, or providing all the tarballs and such in the build tree tpl/cache directory.

Tested builds with and without network, as well as with and without the cached TPLs when the network is present. Also tested all regression tests.

Copy link
Collaborator

@mdavis36 mdavis36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took a while to get around to this, this PR looks good to me 👍

@jmikeowen jmikeowen merged commit b803af9 into develop May 1, 2021
@jmikeowen jmikeowen deleted the bugfix/build-without-network branch May 1, 2021 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants