Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Neighbor tests #85

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Fix for Neighbor tests #85

merged 2 commits into from
Aug 9, 2021

Conversation

mdavis36
Copy link
Collaborator

@mdavis36 mdavis36 commented Aug 5, 2021

Fixes the erroneous test for Neighbor tests. It appears this particular test was incomplete, I think this is might be what was in mind...

jmikeowen
jmikeowen approved these changes Aug 9, 2021
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good -- my only request would be to remove the print statement on line 379 of NeighorTestBase.py. That's the remnant of debug printing, and isn't necessary for normal test running.

@jmikeowen jmikeowen merged commit 3968280 into develop Aug 9, 2021
@mdavis36 mdavis36 deleted the bugfix/Neighbor-Tests branch August 9, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdavis36 @jmikeowen