Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphics flag caused ATS fail w/out X-forwarding terminal #87

Merged
merged 1 commit into from
Sep 22, 2021
Merged

graphics flag caused ATS fail w/out X-forwarding terminal #87

merged 1 commit into from
Sep 22, 2021

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Sep 21, 2021

ATS was failing on the CollisionlessSphereCollapse test. Graphics output was throwing when x-forwarding wasn't enabled.

jmikeowen
jmikeowen approved these changes Sep 22, 2021
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ATS tests should always disable graphics, so this was an oversight.

@jmikeowen jmikeowen merged commit 1ad4ac4 into develop Sep 22, 2021
@jmikeowen jmikeowen deleted the CollisionlessSphereATS_bugfix branch September 22, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmpearl @jmikeowen