-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Logging Updates #501
base: develop
Are you sure you want to change the base?
Conversation
Checkout https://github.com/LLNL/sundials/blob/feature/nls-switching-v7-gs/src/sundials/sundials_logger_impl.h#L35. Now that we have C99 we can change all the logging statements in the code to use a variadic macro and it makes the logging statements much cleaner and gets rid of the repetitive preprocessor checks. My intent was to bring this over from that branch. I can do that here if you think it looks good. |
I was going to ask if you still had the variadic macros from the original logging implementation on another branch. I think switching over to those would be great. It would also be nice to have an "If" version of the macros i.e., something like
into something like
|
@gardner48 The "if" version sounds like a nice addition as well. |
338d18c
to
9614db8
Compare
f604770
to
8ae53d7
Compare
eef87d7
to
b680c0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great; I provided a few suggestions for minor typos, but otherwise this can be approved.
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just a couple quick fixes needed.
Add output files for LLNL/sundials#501
Fix typos in comments Co-authored-by: Cody Balos <balos1@llnl.gov>
Follow on to utilities added in #499