measurement_from_string for single precision

[JensMunkHansen]

I see that measurement_from_string produces a units::precision_measurement. Would it be possible to add one for single precision also.

Would it make sense to rename precision_measurement to precise_measurement in line of precise_unit?

[phlptp]

That makes sense for the precise_measurement for consistency, I will make that change soon. Thanks!

As for getting a measurement from a string, There is unit_cast_from_string to a get a regular unit from the string, but I didn't have an equivalent for the measurement. Not entirely sure what the function should be named? I don't really want to template it, and I want the simplest one to actually be the higher precision.

Any Ideas?

[phlptp]

I changed the name of precision_measurement to precise_measurement so it is consistent throughout the library. Thanks for that suggestion!

I also added measurement_cast_from_string that returns a measurement instead of precise_measurement and added a measurement_cast function. This is consistent with what was in place for units. I can't say I totally like those names but I think the simpler string conversion functions should return the more precise versions of units any measurements even if the names aren't completely consistent. just to be clear that the other can lose information. So I am not entirely sure what to name the versions that return the less precise units/measurement.

Any thoughts?

[JensMunkHansen]

That's great. Totally agree with you on the naming, but cannot come up with better names myself. Thanks for adding the functions for consistency

…

On Mon, Jan 20, 2020, 06:38 Philip Top ***@***.***> wrote: Closed #5 <#5>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=ABQJKYVECAELJEUUHMYLG4LQ6U2EXA5CNFSM4JZVZIL2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWCDPLYA#event-2961634784>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQJKYQRWVQ5JDQB2AEISGLQ6U2EXANCNFSM4JZVZILQ> .