Cmake namespace #136
Merged
Cmake namespace #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com>
…cmake_namespace
Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 6 6
Lines 4780 4790 +10
=======================================
+ Hits 4753 4763 +10
Misses 27 27 |
There was a problem hiding this comment.
As far as I can see, no changes to the unit tests were made, i.e., test cannot be built unless UNITS_NAMESPACE=units. Intentional?
If not, SimonHeybrock@0d9d7ae has the required modifications.
units/units_decl.hpp
Outdated
| constexpr int32_t mole{2}; | ||
| constexpr int32_t radian{3}; | ||
| constexpr int32_t currency{2}; | ||
| constexpr int32_t count{2}; |
There was a problem hiding this comment.
👍 more readable than what I had.
Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com>
units/units_decl.hpp
Outdated
Comment on lines
105
to
112
| meter_(maxNeg(bitwidth::meter)), second_(maxNeg(bitwidth::second)), | ||
| kilogram_(maxNeg(bitwidth::kilogram)), | ||
| ampere_(maxNeg(bitwidth::ampere)), | ||
| candela_(maxNeg(bitwidth::candela)), | ||
| kelvin_(maxNeg(bitwidth::kelvin)), mole_(maxNeg(bitwidth::mole)), | ||
| radians_(maxNeg(bitwidth::radian)), | ||
| currency_(maxNeg(bitwidth::currency)), | ||
| count_(maxNeg(bitwidth::count)), |
There was a problem hiding this comment.
Does this mean we should exclude this here:
Line 18 in 0df7071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a means to change the namespace the units library lives under.
See Issue #110
It can be set using CMAKE with
-DUNITS_NAMESPACE=<desired namespace>or in the code
if nothing is done the namespace defaults to
units