Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse unit multiplier conversion #166

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Sep 10, 2021

Fix issue with converting between inverse units with multiplier values.

Fix Issue #165

@phlptp phlptp linked an issue Sep 10, 2021 that may be closed by this pull request
@phlptp phlptp force-pushed the inverse_unit_multiplier_conversion branch from 74e011d to 9a90804 Compare September 13, 2021 23:29
Co-authored-by: Philip Top <top1@llnl.gov>
Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #166 (9a90804) into main (dc1ff97) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9a90804 differs from pull request most recent head 10a3480. Consider uploading reports for the commit 10a3480 to get more accurate results

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files           9        9           
  Lines        4867     4867           
=======================================
  Hits         4775     4775           
  Misses         92       92           

@phlptp phlptp merged commit 772a3da into main Sep 13, 2021
@phlptp phlptp deleted the inverse_unit_multiplier_conversion branch September 13, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to inverse unit incorrect
2 participants