Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix Intel DRAM overflow issue #328

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

slabasan
Copy link
Collaborator

Description

This patch fixes an overflow problem with Intel's DRAM energy register. Code now checks if the difference in the raw bits is negative, instead of the difference in the joule value.

This still needs testing on a long running application to confirm the problem is resolved.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

  • Comus, spin loop

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my C/C++ code follows the style guidelines of variorum
  • I have run flake8 and black --check --diff and confirm my python code follows the style guidelines of variorum
  • I have run ./scripts/check-rst-format.sh and confirm my documentation follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

@tpatki
Copy link
Member

tpatki commented May 11, 2023

@slabasan I am not sure where we left this after we discovered this in Jessica's data. Do you think we can get this merged in with v0.7, mostly because it impacts correctness?

@slabasan slabasan force-pushed the fix-intel-dram-power-overflow branch from 8e8a552 to c36a1f3 Compare May 11, 2023 22:28
@tpatki
Copy link
Member

tpatki commented Feb 7, 2024

@slabasan : Shall we mark this as "won't-fix" or close this?

slabasan and others added 3 commits March 11, 2024 22:22
Need to check if difference in DRAM bits is negative, not the joule value
@slabasan slabasan force-pushed the fix-intel-dram-power-overflow branch from c36a1f3 to a09a803 Compare March 12, 2024 05:22
@slabasan slabasan added status-ready-for-review Formatted, and tested on multiple systems. and removed status-work-in-progress In progress, not ready to merge. labels Mar 12, 2024
@slabasan slabasan merged commit 7993cfa into LLNL:dev Mar 12, 2024
15 checks passed
@slabasan slabasan added this to the Production: v0.8.0 Release milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-feature-support status-ready-for-review Formatted, and tested on multiple systems. type-bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants