Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change uint<>_t assignments from -1 to 0 #519

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Mar 4, 2024

Description

Change uint64_t assignments from -1 to 0.
Change one matching double assignment from -1 to 0.
Needs verification that all of these assignments have been captured.
Needs testing on corona.

Fixes #485

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

  • Corona

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

Thank you for taking the time to contribute to Variorum!

…assignment from -1 to 0. Needs testing on corona.
@tpatki tpatki added this to the Production: v0.8.0 Release milestone Mar 4, 2024
@tpatki tpatki self-assigned this Mar 4, 2024
@tpatki tpatki changed the title Change uint64_t assignments from -1 to 0. Change uint64_t assignments from -1 to 0 Mar 4, 2024
@tpatki tpatki changed the title Change uint64_t assignments from -1 to 0 Change uint<>_t assignments from -1 to 0 Mar 4, 2024
@tpatki tpatki added status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch and removed status-work-in-progress In progress, not ready to merge. labels Mar 5, 2024
@tpatki tpatki merged commit 6c79e5a into dev Mar 5, 2024
15 checks passed
@slabasan slabasan deleted the fix_unit_neg_assignments branch March 6, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-internal status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch type-internal-cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix negative int assignment to uint64_t and uint32_t
1 participant