Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https:// instead of git:// for cryptomilk #33

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

mohamed
Copy link
Contributor

@mohamed mohamed commented Dec 14, 2018

In many companies, the git:// protocol is blocked by corporate firewall. To circumvent that, use http:// instead of git://

@mohamed
Copy link
Contributor Author

mohamed commented Dec 14, 2018

@salasoom @lindstro BTW, I have just tested "https://" instead of "http://" and that seems to work as well. I leave it up to you guys to decide which protocol to use.

@lindstro
Copy link
Member

@mohamed Interesting. We have the exact reverse problem at LLNL, where pushes over https are blocked, and we have to use git+ssh. But I see no particular issue with changing the protocol for cmocka.

@salasoom Do you agree?

@mohamed
Copy link
Contributor Author

mohamed commented Dec 14, 2018

@lindstro You don't need to push over https. This is simply pulling from the cmocka repo. I hope that LLNL doesn't block read-only https access.

@lindstro
Copy link
Member

@mohamed Right. I was merely pointing out that our default protocol is git+ssh so we can push new zfp code to GitHub. That's probably why we're not using https for pulling cmocka, but as you note, we should be able to do so without problem.

@salasoom
Copy link
Member

We can go with https here. I will rebase the branch against develop, and amend the commit to use https.

@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #33 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #33   +/-   ##
========================================
  Coverage    92.43%   92.43%           
========================================
  Files           46       46           
  Lines         2248     2248           
========================================
  Hits          2078     2078           
  Misses         170      170

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1a464...96eb6b6. Read the comment docs.

@salasoom salasoom changed the title Use http:// instead of git:// for cryptomilk Use https:// instead of git:// for cryptomilk Dec 14, 2018
In many companies, the git:// protocol is blocked by corporate firewall. To circumvent that, use https:// instead of git://
@salasoom salasoom merged commit 23bb883 into LLNL:develop Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants