Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Fix wrong memset params order #83

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

mohamed
Copy link
Contributor

@mohamed mohamed commented Nov 24, 2019

The init value and length parameters of memset were swapped.
This commit fixes that.

Signed-off-by: Mohamed A. Bamakhrama mohamed@alumni.tum.de

The init value and length parameters of memset were swapped.
This commit fixes that.

Signed-off-by: Mohamed A. Bamakhrama <mohamed@alumni.tum.de>
@mohamed mohamed mentioned this pull request Nov 24, 2019
@codecov-io
Copy link

Codecov Report

Merging #83 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #83   +/-   ##
========================================
  Coverage    94.04%   94.04%           
========================================
  Files          233      233           
  Lines         9919     9919           
========================================
  Hits          9328     9328           
  Misses         591      591
Impacted Files Coverage Δ
tests/src/encode/zfpEncodeBlockBase.c 96.29% <100%> (ø) ⬆️
tests/src/decode/zfpDecodeBlockBase.c 96.61% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa79823...7744da9. Read the comment docs.

@lindstro lindstro merged commit 2ab06b3 into LLNL:develop Dec 4, 2019
@lindstro
Copy link
Member

lindstro commented Dec 4, 2019

@mohamed Thanks for finding this bug and submitting a PR.

@mohamed mohamed deleted the hotfix/memset branch December 5, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants