Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch weight to normalized weights. #305

Closed

Conversation

riga
Copy link
Contributor

@riga riga commented Mar 10, 2023

This PR adds the stitchWeight to the EvtW weight in the producers for all years, which effectively renormalizes particular weights and only preserves their shape-changing effect as reported by @dzuolo in #304.

Closes #304.

@dzuolo
Copy link
Contributor

dzuolo commented Mar 10, 2023

This PR adds the stitchWeight to the EvtW weight in the producers for all years, which effectively renormalizes particular weights and only preserves their shape-changing effect as reported by @dzuolo in #304.

Closes #304.

Thanks Marcel! I think you have to re-run only the DY sample during the weekend :)

@dzuolo
Copy link
Contributor

dzuolo commented Mar 10, 2023

This PR adds the stitchWeight to the EvtW weight in the producers for all years, which effectively renormalizes particular weights and only preserves their shape-changing effect as reported by @dzuolo in #304.

Closes #304.

Marcel can you please hold this for a moment? I am just checking the output of the skims after adding the stitchWeight to EvtW and the DY yield is non-sense. I had a doubt but now I am sure it is not needed, here you have my explanation. The stitch weight that was computed before was there to stitch different samples with different XS in a single sample compatible with the inclusive one. Now we are doing something quite different: we have three macro samples (inclusive, jet-binned, pt-binned) and they all have the same XS by construction. The weight we are applying now is quite different: it basically cuts by 1/2 or 1/3 the event yield for events with Z pT larger or greater than 50 GeV so it is not a shape weight but a rough cut we have to apply coming from the fact that we have 2 or 3 time the statistics. I don't know if I made myself clear...

@riga
Copy link
Contributor Author

riga commented Mar 10, 2023

You're right I think. I forgot that the meaning of the stitchWeight completely changed from an actual event-weight to a mere down scaling of n-fold overpopulated phase space regions.

I think we can close this one then.

@portalesHEP
Copy link
Contributor

Sorry I missed this entire discussion. I also agree that the stitchWeight should not be included in the sum of weight. Closing now. (Thanks for looking into it though!)

@kramerto kramerto deleted the feature/renormalize_stitch_weight branch June 6, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing weight in normalization denominator
3 participants