-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy variables #315
Remove legacy variables #315
Conversation
2e154de
to
ba18e8e
Compare
Hey @bfonta ! would it be worth to add to this PR the ParticleNet and b-jet energy regression branches too? |
Hi @bfonta ! I thought you already removed all the additional jets variables, perhaps you want me to write down what has to be added? ;) If so here are the branches in the bigntuples:
|
Ok, I misunderstood. |
4b3ec31
to
d0d2cbd
Compare
82856b8
to
7052a2c
Compare
ad57d50
to
f92ea82
Compare
f92ea82
to
df9124e
Compare
I've rebased on top of #308 and tested the PR with some minor MC samples (ZH_HToBB_ZToQQ and ZH_HToBB_ZToLL); the skimming produces output files as expected. Let me know if everything looks fine, and if there is some additional cleaning we could do. |
Thanks @bfonta ! If more cleaning is needed it can be done in a later PR. For now things look good to me :) |
Sorry for being too slow but why skimOutPutter_HHBtag has been deleted? We must keep it for the systematic uncertainties |
This reverts commit 771571c.
thanks for noticing @dzuolo, and sorry I missed it... I was going to revert the PR, but it may actually be simpler to just retrieve that file (if I did not miss anything else of course) |
Everything else seems ok to me so you can simply retrieve the file. Thanks! |
I removed those files since they both used the following:
which I thought was outdated. |
This PR removes the variables for additional jets as described in #312. Tested successfully on top of #308. Once the latter is merged, this one can follow.