Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy variables #315

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

bfonta
Copy link
Contributor

@bfonta bfonta commented Sep 14, 2023

This PR removes the variables for additional jets as described in #312. Tested successfully on top of #308. Once the latter is merged, this one can follow.

@bfonta bfonta force-pushed the clean/jet_central_and_forward branch from 2e154de to ba18e8e Compare September 15, 2023 17:32
@dzuolo
Copy link
Contributor

dzuolo commented Sep 18, 2023

Hey @bfonta ! would it be worth to add to this PR the ParticleNet and b-jet energy regression branches too?

@bfonta
Copy link
Contributor Author

bfonta commented Sep 18, 2023

@dzuolo Could you please list what has to be removed in #312? On my side I would do it all together then for efficiency!

@dzuolo
Copy link
Contributor

dzuolo commented Sep 18, 2023

Hi @bfonta ! I thought you already removed all the additional jets variables, perhaps you want me to write down what has to be added? ;) If so here are the branches in the bigntuples:

  • ParticleNet
    std::vector<Float_t> _ak8jets_particleNetMDJetTags_probXbb;
    std::vector<Float_t> _ak8jets_particleNetMDJetTags_probXcc;
    std::vector<Float_t> _ak8jets_particleNetMDJetTags_probXqq;
    std::vector<Float_t> _ak8jets_particleNetMDJetTags_probQCD;
    std::vector<Float_t> _ak8jets_particleNetMDJetTags_mass;
  • b-jet energy regression
    std::vector<Float_t> _jets_bJetRegCorr;
    std::vector<Float_t> _jets_bJetRegRes;

@bfonta
Copy link
Contributor Author

bfonta commented Sep 18, 2023

Ok, I misunderstood.
Let us use this PR for cleaning KLUB and open a new one asap to include the missing PNet and b-jet branches.

@bfonta bfonta changed the title WIP: Remove additional jet variables WIP: Remove legacy variables Sep 18, 2023
@bfonta bfonta mentioned this pull request Sep 18, 2023
@bfonta bfonta force-pushed the clean/jet_central_and_forward branch 2 times, most recently from 4b3ec31 to d0d2cbd Compare September 29, 2023 19:54
@bfonta bfonta force-pushed the clean/jet_central_and_forward branch from 82856b8 to 7052a2c Compare November 29, 2023 15:02
@bfonta bfonta marked this pull request as ready for review November 29, 2023 15:02
@bfonta bfonta force-pushed the clean/jet_central_and_forward branch from ad57d50 to f92ea82 Compare November 29, 2023 17:03
@bfonta bfonta force-pushed the clean/jet_central_and_forward branch from f92ea82 to df9124e Compare November 29, 2023 17:07
@bfonta
Copy link
Contributor Author

bfonta commented Nov 30, 2023

I've rebased on top of #308 and tested the PR with some minor MC samples (ZH_HToBB_ZToQQ and ZH_HToBB_ZToLL); the skimming produces output files as expected. Let me know if everything looks fine, and if there is some additional cleaning we could do.

@portalesHEP
Copy link
Contributor

Let me know if everything looks fine, and if there is some additional cleaning we could do.

Thanks @bfonta ! If more cleaning is needed it can be done in a later PR. For now things look good to me :)

@portalesHEP portalesHEP merged commit 771571c into LLRCMS:master Nov 30, 2023
@dzuolo
Copy link
Contributor

dzuolo commented Nov 30, 2023

Sorry for being too slow but why skimOutPutter_HHBtag has been deleted? We must keep it for the systematic uncertainties

portalesHEP added a commit that referenced this pull request Nov 30, 2023
@portalesHEP
Copy link
Contributor

thanks for noticing @dzuolo, and sorry I missed it... I was going to revert the PR, but it may actually be simpler to just retrieve that file (if I did not miss anything else of course)

@dzuolo
Copy link
Contributor

dzuolo commented Nov 30, 2023

thanks for noticing @dzuolo, and sorry I missed it... I was going to revert the PR, but it may actually be simpler to just retrieve that file (if I did not miss anything else of course)

Everything else seems ok to me so you can simply retrieve the file. Thanks!

@bfonta
Copy link
Contributor Author

bfonta commented Nov 30, 2023

I removed those files since they both used the following:

#include "smallTree.h"

which I thought was outdated.

@bfonta bfonta changed the title WIP: Remove legacy variables Remove legacy variables Jan 4, 2024
@bfonta bfonta deleted the clean/jet_central_and_forward branch February 13, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants