Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scripts for DY stitching #88

Merged
merged 6 commits into from
Apr 26, 2020
Merged

Conversation

dzuolo
Copy link
Contributor

@dzuolo dzuolo commented Apr 9, 2020

Created two new scripts to stitch DY samples, including the HT binned ones.
I'm quite confident on the changes made to test/computDYsplitting_HT.cpp but to the ones made to scripts/stitchWeightsDY_HT.py, I'm not sure if I understood correctly the meaning of fractionXS, please review these changes.

if (DEBUG) cout << "NBs = " << nbs << endl;

float ht = theBigTree.lheHt;

Copy link
Contributor

@francescobrivio francescobrivio Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add here a protection like this?

if (ht >= 10000)
{
  cout << --> ev: " << iEvent << " ht is " << ht << " lowered to 9999" << endl;
  ht = 9999.;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!


TFile* fOut = new TFile (outputFileName.c_str(), "recreate");
TH3F* h_nJets_nBs = new TH3F ("h_nJets_nBs" , ";nJets;nBs;ht", 5, xbins, 5, ybins, 9, zbins);
TH3I* hINT_nJets_nBs = new TH3I ("hINT_nJets_nBs", ";nJets;nBs;ht", 5, xbins, 5, ybins, 9, zbins);
Copy link
Contributor

@francescobrivio francescobrivio Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the names of the TH3 histograms here? something like h_nJets_nBs_HT and hINT_nJets_nBs_HT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@camendola
Copy link
Contributor

Ciao @dzuolo, thanks! It looks ok to me, but did you try to test the result of the stitching?

@francescobrivio
Copy link
Contributor

@dzuolo @camendola the file scripts/stitchWeightsDY_HT.py has not been tested and I think should be improved, but maybe we can merge this PR and test it privately, what do you think?
(the other commits and files are fine for me)

@camendola camendola merged commit 0fde4ef into LLRCMS:VBF_legacy Apr 26, 2020
@camendola camendola linked an issue Apr 29, 2020 that may be closed by this pull request
@francescobrivio francescobrivio removed a link to an issue May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants