Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed: Move factories to the same folder as the created object #48

Closed
3 tasks done
Tracked by #16
visto9259 opened this issue May 23, 2024 · 1 comment
Closed
3 tasks done
Tracked by #16
Assignees
Labels
enhancement New feature or request v2 To be implemented in version 2
Milestone

Comments

@visto9259
Copy link
Member

visto9259 commented May 23, 2024

Factories should be closer to the object that it is created. This is will help in understanding the code as one does not have to navigate to the Container folder.

  • Refactor all the factories in Container to the folder of the object that they are creating. For example, LmcRbac\Container\RoleServiceFactory should be refactored to LmcRbac\Role\RoleServiceFactory.
  • Have the original factory extend the new factory and mark it as deprecated
  • Update ConfigProvider to use the new factories
@visto9259 visto9259 added enhancement New feature or request v2 To be implemented in version 2 labels May 23, 2024
@visto9259 visto9259 moved this from 🆕 New to 🏗 In progress in LmcRbac Development May 24, 2024
@visto9259 visto9259 self-assigned this May 24, 2024
@visto9259 visto9259 added this to the 2.0.0 milestone Jul 5, 2024
@visto9259 visto9259 moved this from 🏗 In progress to ✅ Done in LmcRbac Development Aug 6, 2024
@visto9259
Copy link
Member Author

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2 To be implemented in version 2
Projects
Status: Done
Development

No branches or pull requests

1 participant