Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Doctrine Support to a separate companion library #44

Closed
visto9259 opened this issue Feb 16, 2024 · 1 comment
Closed

Move Doctrine Support to a separate companion library #44

visto9259 opened this issue Feb 16, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request v4 To be implemented in version 4

Comments

@visto9259
Copy link
Member

Context:

LmcRbacMvc provide a role provider based on Doctrine ORM which forces to add dependencies to Doctrine for all application, even the ones that are not using Doctrine ORM.
It would be better to have a separate companion library just for the ORM based Role provider

Work to do:

  • Remove Doctrine ORM Role Provided from LmcRbacMvc
  • Create a companion library called LmcRbacMvcDoctrine
  • Update documentation
@visto9259 visto9259 added enhancement New feature or request v4 To be implemented in version 4 labels Feb 16, 2024
@visto9259 visto9259 moved this from 📋 Backlog to 🏗 In progress in LmcRbacMvc Development Feb 16, 2024
@visto9259 visto9259 self-assigned this Feb 16, 2024
@visto9259
Copy link
Member Author

Doctrine is widely used.
This enhancement is probably not required and add minimal overhead, other than having to manage dependencies which would need to done anyway.
Won't do.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in LmcRbacMvc Development May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4 To be implemented in version 4
Projects
Status: Done
Development

No branches or pull requests

1 participant