Fix journaling system bugs #4377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this way might bring undesired results though it won't happen in noticeable frequency. I have a better approach and will add changes in this PR. |
|
The simplest way I can think of is to decouple journaling ID and automation/controller connection. I'll reopen this pull request once it's ready. |
|
Will be superseded with a new fix soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
JournallingObject::changeIDfailed if_idis being used. This commit adds handling of ID collision and partially reverts #2875. So it will fix regressions in #2875, too.Fixes #3781, fixes #3359.