Remember to check for Linux VST Effects #6751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remember to also check .so files and not only .dll
|
I tested this just briefly and it works as intended. Thanks! |
|
IIRC the original Linux VST PR omitted effects intentionally. But if they work correctly, then this looks good to me. |
"only instrument support, but code for effects can be easily done (but in other PR)" I'll look into downloading more dll's tomorrow. More testing needed definitely. Maybe original contributer @akimaze can advice on what was left to do for linuxvst effects in lmms? |
|
LinuxVST works fine. They show in the effect menu, load and play. The gui works and also saving presets. |
zonkmachine
approved these changes
Sep 10, 2023
Veratil
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well...
Looks like we forgot to check for .so files and were only checking for .dll
This pull request should fix this :3