WIP: new effect rack interface and features #7242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be beneficial if you add screenshots here. |
|
I was requested as a reviewer but I am wondering if this PR is already ready for review? The title still says "WIP" and not all checkmarks are checked yet. |
|
Oops mb. Shouldn't have rushed the review call. |
|
I converted it to draft because it's a WIP. Change it back if it's ready. |
|
yes this is a WIP. Still working on it although I expect to have it wrapped up soon |
|
If you don't mind, can you spin off the gate knob removal into it's own seperate Pull Request? Makes it easier to review |
|
Replaced by #7438. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a heavy work-in-progress PR.