feat(autopilot): enable private and minconfs=0 #698
Conversation
There was a problem hiding this comment.
A couple of minor comments on the code @JimmyMow .
Also, could you add your notes about the change into the commit message, and also add a lint like:
Fix #681
into the commit message. Having the fix reference in the commit message will enable github to automatically close out that issue when this is merged, and also allows our changelog to cross reference the PR.
app/lib/lnd/neutrino.js
Outdated
| // Turn autopilot on | ||
| neutrinoArgs.push('--autopilot.active') | ||
| // Ensure all channels opened by autopilot will be flagged private | ||
| neutrinoArgs.push('--autopilot.private') |
There was a problem hiding this comment.
should we move these additional options into resources/lnd.conf? I think the only thing we need to specify dynamically here is the --autopilot.active switch.
app/lib/lnd/neutrino.js
Outdated
| @@ -90,6 +100,7 @@ class Neutrino extends EventEmitter { | |||
| // neutrinoArgs.push('--neutrino.connect=testnet2-btcd.zaphq.io') | |||
| } | |||
|
|
|||
| // this.process = spawn(this.lndConfig.binaryPath, neutrinoArgs) | |||
|
@JimmyMow this needs another update to lnd binary, over and above the one that was merged this morning? |
Pull Request Test Coverage Report for Build 3783
💛 - Coveralls |
fix(neutrino): remove unneeded comments fix(autopilot): move private/minconf to proto
JimmyMow
force-pushed
the
feat/private-0-conf-autopilot
branch
from
0e741d8
to
d162d45
Compare
|
@mrfelton no the current LND version is fine. Squashed commits and moved |
This PR adds private channels and minconfs=0 to our autopilot configuration.
We don't want our light client users advertising channels because they are not likely to be reliable nodes with high uptime. Fixes #681.
NOTE: This PR can only be merged after we update to LND master. These new flags aren't supported with the LND that is currently packaged and LND will shut down on start because of it at the moment. (Customized my binary path to test this works)