Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lifecycle accept node #25

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jan 26, 2023

To compose the accept channel, the peer needs to be in the initial state.

@codecov-commenter
Copy link

Codecov Report

Merging #25 (210c9b1) into master (0063e2c) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@          Coverage Diff           @@
##           master     #25   +/-   ##
======================================
  Coverage    35.1%   35.1%           
======================================
  Files          17      17           
  Lines        1841    1841           
======================================
  Hits          647     647           
  Misses       1194    1194           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dr-orlovsky
Copy link
Contributor

Shouldn't we set the stage to the initial then?

@crisdut
Copy link
Member Author

crisdut commented Jan 30, 2023

Shouldn't we set the stage to the initial then?

There is no need, when channeld is started, the ChannelStage is setted to initial.

@dr-orlovsky
Copy link
Contributor

I prefer to add debug_assert_eq! check for that, at the very least.

Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls see the comment above

Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b08e3b5

@dr-orlovsky dr-orlovsky merged commit 035ae25 into LNP-WG:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants