Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP create API service #7

Merged
merged 1 commit into from
Apr 7, 2020
Merged

WIP create API service #7

merged 1 commit into from
Apr 7, 2020

Conversation

St333p
Copy link
Contributor

@St333p St333p commented Apr 5, 2020

Within the scope of Lightning Hacksprint I tried to implement what's in issue #3.

Not being a Rust developer, I had to guess how some things should be handled and possibly none of this makes sense at all. However this was a great opportunity for me to get a taste of Rust and of this project, both of which will for sure come handy in the future. I'd still love to keep this collaboration going, perhaps after I get a bit more comfortable with the language.

@dr-orlovsky
Copy link
Contributor

dr-orlovsky commented Apr 7, 2020

Thank you very much for you effort and contribution! While the build seems to fail, I will merge it anyway and will edit it afterwards

@dr-orlovsky dr-orlovsky merged commit 2135506 into LNP-WG:master Apr 7, 2020
@St333p
Copy link
Contributor Author

St333p commented Apr 7, 2020

Thank you.
I know, sorry for that. I got some compilation failure that looked like a bug in the compiler from the error message and I couldn't identify where it was from. I hoped for a second it was due to my wrong configuration. I hope before the next contribution I will build a bit of rust proficiency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants