Update dependencies and add support for Postgres as well as Mysql #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denwilliams
force-pushed
the
feature/support_postgres
branch
from
3311dc4
to
7f26ff0
Compare
denwilliams
force-pushed
the
feature/support_postgres
branch
from
7f26ff0
to
53ed1c8
Compare
denwilliams
force-pushed
the
feature/support_postgres
branch
from
ab85511
to
32b6275
Compare
denwilliams
changed the title
|
@smithamax tagging you to see if there is anything else I should add/remove here. Project tests seem to cover it pretty well. Works well in tidy-api with mysql2. Have semi-tested with tidy-api postgres but many raw SQL queries need updating. From the tests here pretty confident it will work. Main thing right now is just to get dependencies updated. |
|
I think in general we should deprecate this lib, but updates look good |
Yeah, Stevo was trying to propose we just get rid of it. Maybe after a tidy refactor, with full typescript it becomes possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Postgres so we can migrate our MySql projects to Postgres for consistency. Would need to rename this project ;)
Updates sequelize and use peer deps for others
This has been tested in tidy-api for mysql, although this PR won't change that anyway.