Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update weight normalization #76

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Update weight normalization #76

merged 2 commits into from
Mar 30, 2024

Conversation

rkansal47
Copy link
Collaborator

@rkansal47 rkansal47 commented Mar 28, 2024 •
edited by cmantill
Loading

  • Separating weights between "norm preserving" (NP) and not-NP
  • NP weights and their sums are saved separately, so each variation of an NP weight can be normalized to 1
  • Update normalization in postprocessing
  • Propagate to get_templates?
  • Test

@rkansal47 rkansal47 requested a review from cmantill March 28, 2024 22:03
cmantill
cmantill approved these changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@cmantill cmantill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested locally w signal sample

@cmantill cmantill merged commit 21d5bd8 into main Mar 30, 2024
9 checks passed
@cmantill cmantill deleted the weight_norm branch March 30, 2024 15:29
@cmantill cmantill mentioned this pull request Mar 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmantill cmantill cmantill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkansal47 @cmantill