Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no-std for optional math libraries #61

Merged

Conversation

Firestar99
Copy link
Contributor

Currently the optional math library dependencies enable the default-features for those libraries, causing eg. glam to enable the std feature, breaking no-std environments like rust-gpu. This PR disables the by default allowing the end user to enable what they need.

I'm unsure but this may break dependent projects if those do not explicitly declare a dependency on the math library, but only use it via this crate. For example glam will get the std feature disabled, but it requires that either std or libm feature is enabled, otherwise it won't compile. But I'd expect that specific case to basically be non-existent and an easy fix: just declare the math library explicitly.

@LPGhatguy
Copy link
Owner

This seems like a reasonable fix to me! I'd be very surprised if anyone depended on Crevice but then did not have the math libraries in their tree configured how they'd like them.

It looks like there might be some CI failures that we probably need to sort out.

@Firestar99
Copy link
Contributor Author

with the latest commit failed CI runs just fine locally

@LPGhatguy LPGhatguy merged commit 124b542 into LPGhatguy:main Nov 3, 2023
6 checks passed
@LPGhatguy
Copy link
Owner

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants