Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor v1 #412

Merged
merged 194 commits into from
Aug 11, 2023
Merged

Refactor v1 #412

merged 194 commits into from
Aug 11, 2023

Conversation

ismael-mendoza
Copy link
Collaborator

@ismael-mendoza ismael-mendoza commented Mar 3, 2023

Copied over from #348 due to a mistake when making a release...

Priority

  • allow DeblendExample to use multiple bands (see Scarlet refactor #421)
  • test and add to tutorial Scarlet deblender

ToDo

  • fix tests (minimal)
  • fix pylint linting
  • linting keep: pylint, flake8, isort, pydocstyle, nbstripout, black
  • add minimal docs, delete old parts
  • delete or cleanup notebooks
  • fix README (minimal)
  • keep precommit?
  • need to add token to publish in pypi (publish.yml)

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 56.03% and project coverage change: -28.63% ⚠️

Comparison is base (ebc7365) 88.00% compared to head (96a7543) 59.37%.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #412       +/-   ##
===========================================
- Coverage   88.00%   59.37%   -28.63%     
===========================================
  Files          11       19        +8     
  Lines        1575     1430      -145     
===========================================
- Hits         1386      849      -537     
- Misses        189      581      +392     
Flag Coverage Δ
unittests 59.37% <56.03%> (-28.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
btk/plotting.py 0.00% <0.00%> (ø)
btk/measure.py 25.00% <21.73%> (-58.58%) ⬇️
btk/deblend.py 37.14% <37.14%> (ø)
btk/metrics/utils.py 38.88% <38.88%> (ø)
btk/sampling_functions.py 49.05% <44.11%> (-45.20%) ⬇️
btk/metrics/segmentation.py 47.82% <47.82%> (ø)
btk/blend_batch.py 51.58% <51.58%> (ø)
btk/metrics/detection.py 60.00% <60.00%> (ø)
btk/multiprocess.py 69.23% <71.42%> (-26.77%) ⬇️
btk/draw_blends.py 76.51% <75.89%> (-14.57%) ⬇️
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ismael-mendoza

This comment was marked as outdated.

@ismael-mendoza

This comment was marked as outdated.

@ismael-mendoza

This comment was marked as outdated.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ismael-mendoza

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants