Real galaxies1 galsim #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thuiop
reviewed
Dec 4, 2020
Co-authored-by: thuiop <thuiop@hotmail.fr>
aboucaud
reviewed
Dec 4, 2020
aboucaud
reviewed
Dec 4, 2020
aboucaud
reviewed
Dec 4, 2020
aboucaud
reviewed
Dec 4, 2020
aboucaud
reviewed
Dec 4, 2020
aboucaud
reviewed
Dec 4, 2020
aboucaud
reviewed
Dec 4, 2020
aboucaud
reviewed
Dec 4, 2020
Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com>
Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com>
Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com>
Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com>
thuiop
reviewed
Dec 4, 2020
|
Hello everyone, thanks for your work in reviews in this PR. I wrote down any outstanding issues I noticed and the ones raised from your comments in #82. We should address them in a later PR but for now I just want to go ahead and merge this one. |
ismael-mendoza
added a commit
that referenced
this pull request
Dec 14, 2020
* * fix up min_snr in draw_blends.py * fixed some names in the obs_conditions.py * start new Galsim class with Remy's functions. * small error * added past Remy's class GalsimRealDraw * added template for Francois * avoid pixel scale clash * fix get psf sky in the utils.py * added code for Remy, in case it's helpful as reference * starting to add functionality for COSMOS catalog * revamped infrastructure for reading multiple catalogs * started template for sampling functions to make compatibility with catalogs explicit * small changes to catalog.py, etc. to be more explicit. * more changes to enforce catalog compatibility * cnosistent naming of table vs. catalog in sampling functions * som more progress in moving the PSF stuff * update and cleanup after rebase * remove verbose Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * name simplify Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * Update btk/catalog.py Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * Update btk/catalog.py Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * Refactor the Catalog objects (#62) * refactor Catalog class * update btk input script * use new catalog factory * update tests * fix variable name * update notebook with Catalog obj * Update btk/sampling_functions.py Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * Update btk/sampling_functions.py Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * use psf as galsim object not drawing it Co-authored-by: Rémy Joseph <remyjoseph@ymail.com> * small formatting changes * Fix the 'size' problem for now * Fix typos in the generator (#65) * Make compatible_catalogs a class attribute (#64) * Fix abstract method call order (#63) * simplifying obs conditions for Remy * Refix the size problem with the improved compatible_catalogs * fixing obs_conditions.py, check Remy? * fixing obs_conditions.py, check Remy? * Use astropy Column to feed size * Add a check to avoid missing columns * Add tests for Catalog obj * Real galaxies1 galsim (#75) * Survey refactoring+CosmosCatalog * Minor refactoring before drawing galsim images * Forgot the .py files * Working drw_single for cosmos * improve type error message related to Surveys Co-authored-by: thuiop <thuiop@hotmail.fr> * Update btk/catalog.py Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * Update btk/catalog.py Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * Update btk/catalog.py Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * Update btk/catalog.py Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * response to review comments Co-authored-by: Ismael Mendoza <11745764+ismael-mendoza@users.noreply.github.com> Co-authored-by: thuiop <thuiop@hotmail.fr> Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> * black * black * Rubin survey was flipped in its order of bands. * deleted some deprecated tests, everything should pass now * no need for galsim_draw Co-authored-by: Alexandre Boucaud <3065310+aboucaud@users.noreply.github.com> Co-authored-by: Rémy Joseph <remyjoseph@ymail.com> Co-authored-by: Thomas Sainrat <thomas.sainrat@student-cs.fr> Co-authored-by: Alexandre Boucaud <boucaud.alexandre@gmail.com> Co-authored-by: thuiop <thuiop@hotmail.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behold the first galsim real images generated with BTK!
There is still a long way to go. Now all the functionalities for generating images are there, but it looks like the draw_blend and draw_single don't talk to each other that well. Namely, the fluxes are off, as well as the. position and I had to put a few random number to generate the image at this point. I think I know how to solve most of these issues, but I think we are safe pulling this branch now and solving the rest later or even in a completely different PR.