Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace m2r2 with sphinx_mdinclude #1005

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Replace m2r2 with sphinx_mdinclude #1005

merged 2 commits into from
Nov 17, 2022

Conversation

hsinfan1996
Copy link
Contributor

No description provided.

@hsinfan1996 hsinfan1996 linked an issue Nov 16, 2022 that may be closed by this pull request
RTD package dependency #1001
Closed
@coveralls
Copy link

coveralls commented Nov 16, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3481743777

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.562%
Totals Coverage Status
Change from base Build 3481038780: 0.0%
Covered Lines: 4842
Relevant Lines: 4963
💛 - Coveralls

@damonge
Copy link
Collaborator

damonge commented Nov 16, 2022

I think something happened in #977 broke the tests (even though the tests in that PR had passed). I'll try to sort it out

@damonge
Copy link
Collaborator

damonge commented Nov 16, 2022

@hsinfan1996 the test currently failing is fixed in #977. If you review it, we can merge it quickly and then this one.

damonge
damonge approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge and I'll check that the docs look good once that's done.

@hsinfan1996 hsinfan1996 merged commit 0708c59 into master Nov 17, 2022
@hsinfan1996 hsinfan1996 deleted the replace_m2r2_dependency branch November 17, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonge damonge damonge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTD package dependency
3 participants
@hsinfan1996 @coveralls @damonge