Emu pk #1094
Merged
Emu pk #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matteozennaro flake8 is failing (from experience, best run this on your machine before pushing). Do |
|
The tests are failing because they can't import baccoemu. Try getting it to install by adding it here: https://github.com/LSSTDESC/CCL/blob/master/.github/environment.yml |
damonge
requested changes
Jul 5, 2023
There was a problem hiding this comment.
Thanks a lot @matteozennaro . This was super quick and it's really great to have these implemented. Just a few comments below.
…re self explanatory names, unified emulator type in cosmology
…tand why it fails
Pull Request Test Coverage Report for Build 5510615878
💛 - Coveralls |
damonge
reviewed
Jul 5, 2023
… expansion factors used to create the 2d interpolator of the nonlinear pk emulators not hardcoded
… matter power spectrum
…ded for aemulus heft)
|
May be related lesgourg/class_public#416 |
…king because of pip installation of ee2 and class version for aemulus). Will be reintroduced later in a dedicated pull request.
damonge
reviewed
Jul 10, 2023
…n when cosmology is set up with A_s
…stent with CCL h-units convention)
damonge
reviewed
Jul 10, 2023
This was referenced Jul 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable passing linear and nonlinear pk emulators to the cosmology class (baccoemu and euclid emulator 2 implemented for now, generic emulator class introduced extendable to other emulators). Added baccoemu baryonic effect emulator to baryons class.