Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve NFW and Hernquist _fx_projected and _fx_cumul2d #1096

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Improve NFW and Hernquist _fx_projected and _fx_cumul2d #1096

merged 2 commits into from
Jul 10, 2023

Conversation

hsinfan1996
Copy link
Contributor

Use np.arcsinh and np.arcsin for numerical stability when xx is close to 1.

@hsinfan1996 hsinfan1996 linked an issue Jul 7, 2023 that may be closed by this pull request
Numerical instability of Hernquist _fx_projected and _fx_cumul2d when x is close to 1 #1095
Closed
@coveralls
Copy link

coveralls commented Jul 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5491226734

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.546%
Totals Coverage Status
Change from base Build 5199196746: 0.003%
Covered Lines: 5128
Relevant Lines: 5257
💛 - Coveralls

damonge
damonge approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsinfan1996 hsinfan1996 merged commit cad503b into master Jul 10, 2023
@hsinfan1996 hsinfan1996 deleted the fix_profile_arccos branch July 10, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonge damonge damonge approved these changes

@nikfilippas nikfilippas Awaiting requested review from nikfilippas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numerical instability of Hernquist _fx_projected and _fx_cumul2d when x is close to 1
3 participants
@hsinfan1996 @coveralls @damonge