Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick bugfix in sigma2_B_from_mask #1167

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Quick bugfix in sigma2_B_from_mask #1167

merged 1 commit into from
Mar 20, 2024

Conversation

damonge
Copy link
Collaborator

@damonge damonge commented Mar 19, 2024

Closes #1158

@damonge damonge mentioned this pull request Mar 19, 2024
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8343436273

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.484%
Totals Coverage Status
Change from base Build 8206502277: 0.0%
Covered Lines: 6547
Relevant Lines: 6716
💛 - Coveralls

nikfilippas
nikfilippas approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@nikfilippas nikfilippas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damonge damonge merged commit 9ce2f6d into master Mar 20, 2024
4 checks passed
@damonge damonge deleted the sigma_b_from_mask_pk_input_fix branch March 20, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikfilippas nikfilippas nikfilippas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected consistency between sigma2_B_from_mask and sigma2_B_disc for large fsky
3 participants
@damonge @coveralls @nikfilippas