Super Sample Covariance with linear galaxy bias approximation #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2575225889
💛 - Coveralls |
damonge
requested changes
Jun 28, 2022
|
@damonge back to you! |
damonge
reviewed
Jun 28, 2022
damonge
requested changes
Jun 28, 2022
|
@damonge back to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first implementation in TJPCov, in order to avoid the user to have to define several halo model parameters, it might be useful to have an approximation of the SSC. What I have implemented here is
tkk_ssc ~ b1 * b2 * First_term_for_a_NFW_profile + (b1 * delta_1_nc + b2 * delta_2_nc) * Pmm_for_a_NFW_profile(see Eq. A13 in 1601.05779), wheredelta_1_nc = 1if the first quantity is for number counts and 0 if not.I have also fixed the docstring for the SSC trispectrum function.