Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better docs for correlations #974

Merged
merged 6 commits into from
Aug 5, 2022
Merged

Better docs for correlations #974

merged 6 commits into from
Aug 5, 2022

Conversation

damonge
Copy link
Collaborator

@damonge damonge commented Aug 5, 2022

We need to warn users that calculating correlations may depend on the values of the spline parameters (particularly if they're going down to inordinately small scales). This adds a note on this in the documentation.

Closes #826

@coveralls
Copy link

coveralls commented Aug 5, 2022

Pull Request Test Coverage Report for Build 2805437035

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.503%

Totals Coverage Status
Change from base Build 2805039491: 0.0%
Covered Lines: 4842
Relevant Lines: 4966

💛 - Coveralls

Copy link
Contributor

@nikfilippas nikfilippas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damonge damonge merged commit 87076bc into master Aug 5, 2022
@damonge damonge deleted the fix_826 branch August 5, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correlation function calculation at small angular separation
3 participants