Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kwargs option in fitter #419

Merged
merged 13 commits into from
Jul 20, 2021
Merged

Add kwargs option in fitter #419

merged 13 commits into from
Jul 20, 2021

Conversation

marina-ricci
Copy link
Collaborator

@marina-ricci marina-ricci commented Jul 13, 2021 •
edited
Loading

This PR address issue #418 and issue #420.

@coveralls
Copy link

coveralls commented Jul 13, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 863ceb1 on issue_418 into c2628bd on master.

m-aguena
m-aguena reviewed Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@m-aguena m-aguena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart fix, but it would be good do add docs accordingly.

clmm/support/sampler.py Outdated Show resolved Hide resolved
@marina-ricci
Copy link
Collaborator Author

@m-aguena I did not change the notebook as setting the default value of absolute_sigma to True should work.

@marina-ricci marina-ricci added this to the v1.0 Code Release milestone Jul 16, 2021
@marina-ricci
Copy link
Collaborator Author

I don't understand what is going on with the documentation fail.

@hsinfan1996
Copy link
Collaborator

hsinfan1996 commented Jul 16, 2021 •
edited
Loading

@marina-ricci Thanks. I feel like doing this for a long time. I will update the Example 1 notebook accordingly in order to use the new basin-hopping sampler.

@hsinfan1996 hsinfan1996 force-pushed the issue_418 branch 2 times, most recently from 2904b98 to 7546686 Compare July 16, 2021 20:20
aimalz
aimalz requested changes Jul 20, 2021
View reviewed changes
clmm/support/sampler.py Show resolved Hide resolved
clmm/support/sampler.py Outdated Show resolved Hide resolved
@combet combet linked an issue Jul 20, 2021 that may be closed by this pull request
Allowing to pass more keywords to the fitters #418
Closed
@combet combet linked an issue Jul 20, 2021 that may be closed by this pull request
Bug documentation in theory #420
Closed
@combet combet requested a review from aimalz July 20, 2021 13:34
@aimalz aimalz merged commit 792379b into master Jul 20, 2021
@aimalz aimalz deleted the issue_418 branch July 20, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsinfan1996 hsinfan1996 hsinfan1996 left review comments

@combet combet combet left review comments

@m-aguena m-aguena m-aguena left review comments

@aimalz aimalz aimalz approved these changes

Assignees
No one assigned
Labels
PR: Ready for Review
Projects
None yet
Milestone
v1.0 Code Release
Development

Successfully merging this pull request may close these issues.

Bug documentation in theory Allowing to pass more keywords to the fitters
6 participants
@marina-ricci @coveralls @hsinfan1996 @aimalz @m-aguena @combet