Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rectpix both #39

Merged
merged 55 commits into from
Feb 6, 2019
Merged

Rectpix both #39

merged 55 commits into from
Feb 6, 2019

Conversation

damonge
Copy link
Collaborator

@damonge damonge commented Jan 12, 2019

Opened this PR on behalf of @xzackli , who has done all of the work

xzackli and others added 30 commits December 9, 2018 23:28
@xzackli
added curved sky structure which will replace nside throughout
40939eb
@xzackli
modified nmt_field_read and nmt_field, preparing for mode coupling ch…
12de6a5 
…anges
@xzackli
moving back to master, changing the interface again for a more system…
b0d38b5 
…atic approach
@xzackli
modified nmt_field_CAR functions and recovered behavior up to nmt_read
9896586
@xzackli
reverted tests
855bd5f
@xzackli
first working CAR power spectrum
f3a9103
@xzackli
added demo notebooks, polishing
fb9400e
@xzackli
added a label to the ACT notebook
33171d6
@xzackli
added some text about CAR map being a ring
b4eb6b8
@xzackli
removed comments in ACT_test with todo list (hehe)
7467e5e
@xzackli
added a missing malloc for comment
a0e097e
@xzackli
added malloc to get_file_params too
6856f44
@xzackli
fixed CAR reading for multiple columns
80ed37b
@xzackli
polarization now tested and working
d06c8fe
@xzackli
added polarization testing notebook
a67b845
@xzackli
added read/write nmt_workspace_CAR functions
f22e6b2
@xzackli
accept CAR maps which are not full rings
a3ee813
@damonge
changes propagated in healpix_extra.c
a718ac3
@damonge
propagated to nmt_field.c
b571127
@damonge
propagated to nmt_master.c
f117084
@damonge
propagated to nmt_covar.c
51a611e
@damonge
propagated to unit tests and it compiles
b29dca5
@damonge
healpix_extra tests passing
6b4cd53
@damonge
tests pass for field and master
4cc0f35
@damonge
all unit tests working, updated benchmark MCMs, wrapped nmt_curvedsky…
00da714 
…_info copying
@damonge
propagated into python - no CAR in python yet. All tests passing
a82f9e4
@damonge
changes propagated into python, need unit tests everywhere
62123d0
@damonge
started with unit tests, fixed a couple of bugs
5f2ff64
@damonge
homogenized interpretation of CAR variables within a Clenshaw-Curtis …
74880ef 
…grid
@damonge
got started with some unit tests
df06702
damonge and others added 25 commits January 17, 2019 21:15
@damonge
more testing, changed the way theta0 is interpreted, still needs to b…
0668861 
…e propagated to other functions
@damonge
fixed small array bound problem
af41e95
@damonge
specified CC constraints in documentation, synfast unit test, further…
3f1a9b8 
… test in curvedsky_info creator
@damonge
started wcs handling in python
c7c0232
@xzackli
slight modifications to conform to WCS FITS
8db53f1
@xzackli
added example cosmojpg in test_rectpix.c
d1c8e36
@damonge
debugged wcs handling in python
d0c9271
@damonge
Merge branch 'rectpix_dam' of github.com:LSSTDESC/NaMaster into rectp…
3b9e6e4 
…ix_dam
@damonge
synfast in CAR
d63c4a4
@xzackli
added he_write_CAR_map() for debugging, still untested
4d827fc
@damonge
cosmetic
1de5b84
@damonge
Merge branch 'rectpix_dam' of github.com:LSSTDESC/NaMaster into rectp…
00fea64 
…ix_dam
@damonge
first python unit tests - field
591986b
@damonge
added missing file
874caaa
@damonge
more testing - master not ready yet
d0194a7
@damonge
niter set to 0 by default
59475a9
@damonge
changed workspace bounds check to allow for larger input power spectra
31e5cdb
@damonge
allowed for l1<lmax_large (which is not necessarily 3*nside-1 for CAR…
ed31b8e 
…), niter back to 3 for the time being
@damonge
n_iter now fully tunable
b0a7758
@damonge
merged master
3bab327
@damonge
C tests for hpex and CAR field
62ce6a3
@damonge
finished CAR unit tests
6952b02
@damonge
skip long tests in travis
de00648
Merge pull request #40 from LSSTDESC/rectpix_dam
0827c12 
CAR pixelization, now with python support and testing
@xzackli
removed dev folder containing test scripts
9a19dbe
xzackli
xzackli approved these changes Feb 6, 2019
View reviewed changes
Copy link
Collaborator

@xzackli xzackli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, extraneous files removed, we benchmarked the code against pspy. Seems ready to merge!

damonge
damonge commented Feb 6, 2019
View reviewed changes
Copy link
Collaborator Author

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty!

@damonge damonge merged commit e162b6f into master Feb 6, 2019
@damonge damonge deleted the rectpix_both branch February 6, 2019 15:25
@xzackli xzackli mentioned this pull request Feb 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzackli xzackli xzackli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damonge @xzackli