Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qp.PDF approximate and evaluate return NaN for Samples if min or max value has multiple entries #3

Closed
sschmidt23 opened this issue Jul 25, 2017 · 3 comments

Comments

@sschmidt23
Copy link
Collaborator

qp.PDF() objects using approximate and evaluate return NaN outside the region of support if Samples are used and if the min or max value has multiple entries that are the same value. This is due to scipy.interp.interp1d and fill_value="extrapolate", where it fails to estimate a slope at the end point, breaking extrapolation. This should be fixable by setting fill_value = zero or a tiny number when using samples.

@drphilmarshall
Copy link

drphilmarshall commented Jul 26, 2017 via email

@aimalz
Copy link
Collaborator

aimalz commented Jul 27, 2017

I'm closing this issue since it's a problem with qp, not with the DC1 scripts. Further discussion should happen over at #78 on qp.

@aimalz aimalz closed this as completed Jul 27, 2017
@aimalz
Copy link
Collaborator

aimalz commented Jul 28, 2017

@sschmidt23 issue/78/extrapolation now includes a fix for this bug. It should be merged into master as soon as @drphilmarshall can review #81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants