Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding phoSim indexing failures in Run 3 #312

Closed
rbiswas4 opened this issue Sep 8, 2016 · 6 comments
Closed

Avoiding phoSim indexing failures in Run 3 #312

rbiswas4 opened this issue Sep 8, 2016 · 6 comments

Comments

@rbiswas4
Copy link
Member

rbiswas4 commented Sep 8, 2016

@drphilmarshall
Is there a plan to avoid indexing failures due to phosim for run3 ? As a reminder in previous runs, we have found and reported that PhoSim tries to index objects by floats, and indices are messed up due to precision problems when these are large. I do not know if phosim was changed to avoid this problem. I forgot to mention this during the meeting.

A possibility could be checking out our own branch of phosim and modfiying the index to a string before writing it out. We can then tag this and use this tagged version. I will not have time to work on it immediately.

@drphilmarshall
Copy link
Contributor

drphilmarshall commented Sep 9, 2016 via email

@jchiang87
Copy link
Contributor

This doesn't seem to have been issued there:
https://bitbucket.org/phosim/phosim_release/issues

@drphilmarshall
Copy link
Contributor

drphilmarshall commented Sep 9, 2016 via email

@drphilmarshall drphilmarshall changed the title Indexing Failures for Run 3 Avoiding phoSim indexing failures in Run 3 Sep 21, 2016
@drphilmarshall drphilmarshall added this to the Twinkles 1 (Run 3) Data Generation Start milestone Sep 21, 2016
@rbiswas4
Copy link
Member Author

@rbiswas4
Copy link
Member Author

This issue (specific to run 3) should be closed by #340 . However, I think we should track this general issue.

@rbiswas4
Copy link
Member Author

rbiswas4 commented Nov 4, 2016

Closed through #340 for run 3 and kept track of in genral in #383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants