Fix scipy.fsolve failure when computing r0_500 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchiang87
approved these changes
Sep 8, 2018
|
I'll merge this tomorrow at 9am PT, unless I hear otherwise. |
|
Ah, forgot to come back to this. Thanks Jim. Is the numpy version bumped in the latest release? |
|
Yes, it's at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where newer versions of scipy.fsolve (sensibly) require the output of the residual function to have the same dimensions as the input. We were previously producing a vector residual from a scalar input due to broadcasting the vector
L0parameter. This PR scalarizes the inputL0, and also plays a bit more defensively against possible vector inputs that may, for instance, be employed by fsolve itself.