Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite InstCatTrimmer class to save memory ingesting Run2.0i instance catalogs #161

Merged
merged 5 commits into from
Nov 14, 2018

Conversation

jchiang87
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Sep 11, 2018

Coverage Status

Coverage decreased (-0.3%) to 71.857% when pulling 2f4df8a on u/jchiang/instcat_memory_fix into 842bf9c on master.

@rmjarvis
Copy link
Contributor

rmjarvis commented Nov 7, 2018

Can this be merged into dc2_run2.0_rc? @villarrealas is unable to run with GalSim 2.0 without the fix on this branch in commit 27b8257.

Copy link

@tomuram tomuram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal change looks okay to me; trusting that this change conforms to the galsim interface

@jchiang87 jchiang87 merged commit 08eb943 into master Nov 14, 2018
@jchiang87 jchiang87 deleted the u/jchiang/instcat_memory_fix branch November 14, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants