Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add header keywords for jointcal #194

Merged
merged 7 commits into from
Dec 5, 2018
Merged

add header keywords for jointcal #194

merged 7 commits into from
Dec 5, 2018

Conversation

jchiang87
Copy link
Collaborator

These changes add keywords mentioned at #178 (comment)

@cwwalter It would be good to review this right away so that it can be included in the tag for Run2.1i.

cwwalter
cwwalter approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@cwwalter cwwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I don't see any problems here. I asked a few questions mostly related to details of things I don't know related to very specific things about our coordinate system. It wouldn't be bad for @timj to take a look at this.

python/desc/imsim/camera_info.py Show resolved Hide resolved
python/desc/imsim/camera_info.py Outdated Show resolved Hide resolved
python/desc/imsim/camera_readout.py Outdated Show resolved Hide resolved
python/desc/imsim/camera_readout.py Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 73.282% when pulling 687ac62 on issue/178/header_keywords_for_jointcal into 5d8ef80 on master.

@jchiang87 jchiang87 merged commit 47a402f into master Dec 5, 2018
@jchiang87 jchiang87 deleted the issue/178/header_keywords_for_jointcal branch December 5, 2018 00:46
@cwwalter cwwalter mentioned this pull request Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwwalter cwwalter cwwalter approved these changes

@rmjarvis rmjarvis rmjarvis left review comments

@timj timj timj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jchiang87 @coveralls @timj @rmjarvis @cwwalter