Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip dsps notebook in smoke test #143

Merged
merged 1 commit into from
May 21, 2024
Merged

skip dsps notebook in smoke test #143

merged 1 commit into from
May 21, 2024

Conversation

ztq1996
Copy link
Contributor

@ztq1996 ztq1996 commented May 20, 2024

Problem & Solution Description (including issue #)

Until further notice

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@ztq1996 ztq1996 requested a review from hangqianjun May 20, 2024 19:48
Copy link
Contributor

@hangqianjun hangqianjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hangqianjun hangqianjun merged commit 8292cb7 into main May 21, 2024
5 checks passed
@ztq1996 ztq1996 deleted the tqz/skip_smoketest branch May 23, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants