Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bpz files; reduce duplicated logic in if/else #76

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

OliviaLynn
Copy link
Member

@OliviaLynn OliviaLynn commented Nov 14, 2023

Problem & Solution Description (including issue #)

For the bpz portion of rail#48.

  • I wasn't 100% sure if we wanted to keep the other (non-tar) data separate like the tar data.

  • If downloading test_dc2_training_9816_broadtypes.hdf5 and test_dc2_train_customtemp_broadttypes.hdf5 from NERSC along with the tar works for people, here's a PR for that.

  • This PR also reduces the duplicated logic across the if/else branching.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (263b2a6) 96.96% compared to head (e125207) 96.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files          32       32           
  Lines        1714     1714           
=======================================
  Hits         1662     1662           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sschmidt23 sschmidt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Olivia

@OliviaLynn OliviaLynn merged commit fd13285 into main Nov 21, 2023
7 checks passed
@OliviaLynn OliviaLynn deleted the user/olynn/update-get-data branch November 21, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants