Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete added_examples directory #13

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Delete added_examples directory #13

merged 1 commit into from
Nov 29, 2023

Conversation

OliviaLynn
Copy link
Member

Problem & Solution Description (including issue #)

Removing the example notebook as part of LSSTDESC/rail#48

Notebook is now available within the umbrella rail package at https://github.com/LSSTDESC/rail/blob/main/examples/estimation_examples/GPz_estimation_example.ipynb

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a26b66c) 64.11% compared to head (8f2c6d1) 64.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   64.11%   64.11%           
=======================================
  Files           2        2           
  Lines         510      510           
=======================================
  Hits          327      327           
  Misses        183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@OliviaLynn OliviaLynn merged commit ab4937b into main Nov 29, 2023
7 checks passed
@OliviaLynn OliviaLynn deleted the user/olynn/remove-demo branch November 29, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants