Issue/84/add qp #85
Merged
Issue/84/add qp #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've asked the cluster people if requiring 3.8+ would be a problem for them - they are looking into it. |
|
TJPCov have an issue to look into updating here: |
|
Aside from that, thoughts on the pr?On Apr 17, 2023, at 8:57 AM, joezuntz ***@***.***> wrote:
TJPCov have an issue to look into updating here:
LSSTDESC/TJPCov#85
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
joezuntz
requested changes
Apr 21, 2023
|
@eacharles reminder that there's one cut/paste to do to finish this! |
|
Have another look. I had to rebase to master and I hope I got it right. |
joezuntz
approved these changes
May 3, 2023
|
I have never understood rebasing, but this seems to work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.