U/jrbogart/remove sncosmo #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchiang87
approved these changes
Jun 18, 2024
skycatalogs/catalog_creator.py
Outdated
| @@ -295,12 +295,16 @@ def __init__(self, parts, area_partition=None, skycatalog_root=None, | |||
| _cosmo_cat = 'cosmodc2_v1.1.4_image_addon_knots' | |||
| _diffsky_cat = 'roman_rubin_2023_v1.1.2_elais' | |||
| _star_db = '/global/cfs/cdirs/lsst/groups/SSim/DC2/dc2_stellar_healpixel.db' | |||
| _sn_db = '/global/cfs/cdirs/lsst/groups/SSim/DC2/cosmoDC2_v1.1.4/sne_cosmoDC2_v1.1.4_MS_DDF_healpix.db' | |||
| # _sn_db = '/global/cfs/cdirs/lsst/groups/SSim/DC2/cosmoDC2_v1.1.4/sne_cosmoDC2_v1.1.4_MS_DDF_healpix.db' | |||
There was a problem hiding this comment.
It seems like this line should just be deleted.
skycatalogs/catalog_creator.py
Outdated
Comment on lines
329
to
331
| # self._sn_truth = sn_truth | ||
| # if self._sn_truth is None: | ||
| # self._sn_truth = _sn_db |
|
I'll get rid of the unneeded commented-out lines before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for sncosmo object type. Includes removal of sncosmo dependency.
Allow sky catalogs pointsource files to have more than one row group of stars.